Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1361813003: Revert "Avoid warning when using `return;` from sync* and async* functions." (Closed)

Created:
5 years, 3 months ago by sigurdm
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Avoid warning when using `return;` from sync* and async* functions." This reverts commit 75f80a204b98ebd65a5da1f2c1db6c6388d67887. BUG= Committed: https://github.com/dart-lang/sdk/commit/8163c4a14199314b6fad626de61d031a35b4d2c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/async_return_types_test.dart View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sigurdm
TBR
5 years, 3 months ago (2015-09-23 10:21:42 UTC) #2
sigurdm
5 years, 3 months ago (2015-09-23 10:22:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8163c4a14199314b6fad626de61d031a35b4d2c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698