Remove some usages of IterableMixinWorkaround from HTML library.

Remove some usages of IterableMixinWorkaround from HTML library.

I haven't found a way to remove the usages in
  immutable_list_mixin.darttemplate
yet, since it requires understanding the Python code using the template.

Committed: https://code.google.com/p/dart/source/detail?r=21187

[Lasse Reichstein Nielsen, 2013-04-08 11:41:40]

Based on the previous CL that made ListBase publicly available.

[floitsch, 2013-04-08 15:33:14]

LGTM.

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Node.darttemplate (right):

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Node.darttemplate:108: void
removeAll(Iterable elements) {
Explain why this doesn't come from the ListBase.

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Node.darttemplate:131: _filter(test, true);
ditto.

[floitsch, 2013-04-08 15:33:31]

Adding blois@.

[blois, 2013-04-08 15:45:45]

For the immutable_list_mixin.darttemplate, it's going to be a bit more
problematic as a number of classes which use it extend something else. For
example _CssValueList and all of the ArrayBufferViews.

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Element.darttemplate:185:
_nodeList.removeAll(elements);
Should this be _childElements?

[floitsch, 2013-04-08 15:49:13]

On 2013/04/08 15:45:45, blois wrote:
> For the immutable_list_mixin.darttemplate, it's going to be a bit more
> problematic as a number of classes which use it extend something else. For
> example _CssValueList and all of the ArrayBufferViews.
There we are going to use mixins.
> 
>
https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
> File tools/dom/templates/html/impl/impl_Element.darttemplate (right):
> 
>
https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
> tools/dom/templates/html/impl/impl_Element.darttemplate:185:
> _nodeList.removeAll(elements);
> Should this be _childElements?

[Lasse Reichstein Nielsen, 2013-04-10 09:03:54]

Committed patchset #2 manually as r21187 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-04-11 07:28:19]

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Element.darttemplate:185:
_nodeList.removeAll(elements);
Absolutely, good catch.

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Node.darttemplate (right):

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Node.darttemplate:108: void
removeAll(Iterable elements) {
On 2013/04/08 15:33:14, floitsch wrote:
> Explain why this doesn't come from the ListBase.

Done.

https://codereview.chromium.org/13617003/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Node.darttemplate:131: _filter(test, true);
On 2013/04/08 15:33:14, floitsch wrote:
> ditto.

Done.