Issue 1361213005: Fix hidden bug with isolate shutdown debugger events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1361213005: Fix hidden bug with isolate shutdown debugger events (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix hidden bug with isolate shutdown debugger events A CL from July (https://codereview.chromium.org/1168933002), papered over (see ASSERT removal in dbg_message.cc) a bug where we would send isolate shutdown event for the service isolate even though no isolate create event was sent. This CL: - Restores the ASSERT in dbg_message.cc - Fixes the service isolate shutdown path so that the shutdown event is no longer sent. Committed: https://github.com/dart-lang/sdk/commit/0b931dbc007ff9d8574c8bd80a8e42723f936cfe

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	runtime/bin/dbg_message.cc	View		1 chunk	+11 lines, -12 lines	0 comments	Download
	M	runtime/vm/service_isolate.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

TBR=turnidge This because it is blocking rolling Dart forward in Mojo.

5 years, 3 months ago (2015-09-24 14:01:08 UTC) #3

Cutch

Committed patchset #2 (id:20001) manually as 0b931dbc007ff9d8574c8bd80a8e42723f936cfe (presubmit successful).

5 years, 3 months ago (2015-09-24 14:01:21 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages