Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1361213003: Distinguish internal kill messages from user-initiated kill messages. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Distinguish internal kill messages from user-initiated kill messages. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c553cd065a7314f58fd614c9a45626957a71e18f

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
M runtime/vm/debugger.cc View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 6 chunks +33 lines, -21 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 3 months ago (2015-09-23 20:28:46 UTC) #2
Cutch
lgtm https://codereview.chromium.org/1361213003/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/1361213003/diff/20001/runtime/vm/raw_object.h#newcode1462 runtime/vm/raw_object.h:1462: bool is_user_initiated_; Usually these fields go *after* to()
5 years, 3 months ago (2015-09-24 17:12:58 UTC) #3
turnidge
Committed patchset #2 (id:20001) manually as c553cd065a7314f58fd614c9a45626957a71e18f (presubmit successful).
5 years, 3 months ago (2015-09-24 17:22:10 UTC) #4
turnidge
5 years, 3 months ago (2015-09-24 17:22:53 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1361213003/diff/20001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/1361213003/diff/20001/runtime/vm/raw_object.h...
runtime/vm/raw_object.h:1462: bool is_user_initiated_;
On 2015/09/24 17:12:58, Cutch wrote:
> Usually these fields go *after* to()

Done.

Powered by Google App Engine
This is Rietveld 408576698