Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1361163002: remove docgen remnants from repo, update CHANGELOG (Closed)

Created:
5 years, 3 months ago by keertip
Modified:
5 years, 3 months ago
Reviewers:
Bill Hesse, Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3409 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 4 chunks +0 lines, -6 lines 0 comments Download
M pkg/pkgbuild.status View 1 1 chunk +0 lines, -1 line 0 comments Download
D sdk/bin/docgen View 1 1 chunk +0 lines, -7 lines 0 comments Download
D sdk/bin/docgen.bat View 1 1 chunk +0 lines, -7 lines 0 comments Download
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D utils/apidoc/.gitignore View 1 1 chunk +0 lines, -22 lines 0 comments Download
D utils/apidoc/README.txt View 1 1 chunk +0 lines, -86 lines 0 comments Download
D utils/apidoc/apidoc.dart View 1 1 chunk +0 lines, -477 lines 0 comments Download
D utils/apidoc/docgen.gyp View 1 1 chunk +0 lines, -102 lines 0 comments Download
D utils/apidoc/html_diff.dart View 1 1 chunk +0 lines, -231 lines 0 comments Download
D utils/apidoc/lib/metadata.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
D utils/apidoc/mdn/README.txt View 1 1 chunk +0 lines, -76 lines 0 comments Download
D utils/apidoc/mdn/crawl.js View 1 1 chunk +0 lines, -120 lines 0 comments Download
D utils/apidoc/mdn/data/dartIdl.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D utils/apidoc/mdn/data/domTypes.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D utils/apidoc/mdn/extract.dart View 1 1 chunk +0 lines, -1321 lines 0 comments Download
D utils/apidoc/mdn/extract.sh View 1 1 chunk +0 lines, -19 lines 0 comments Download
D utils/apidoc/mdn/extractRunner.js View 1 1 chunk +0 lines, -194 lines 0 comments Download
D utils/apidoc/mdn/full_run.sh View 1 1 chunk +0 lines, -8 lines 0 comments Download
D utils/apidoc/mdn/obsolete.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D utils/apidoc/mdn/postProcess.dart View 1 1 chunk +0 lines, -38 lines 0 comments Download
D utils/apidoc/mdn/prettyPrint.dart View 1 1 chunk +0 lines, -430 lines 0 comments Download
D utils/apidoc/mdn/search.js View 1 1 chunk +0 lines, -58 lines 0 comments Download
D utils/apidoc/mdn/util.dart View 1 1 chunk +0 lines, -95 lines 0 comments Download
D utils/apidoc/static/apidoc-styles.css View 1 1 chunk +0 lines, -92 lines 0 comments Download
D utils/apidoc/static/mdn-logo-tiny.png View 1 Binary file 0 comments Download

Messages

Total messages: 6 (1 generated)
keertip
5 years, 3 months ago (2015-09-23 16:44:09 UTC) #2
Alan Knight
I don't seem to be able to patch this to verify, but seems reasonable. LGTM ...
5 years, 3 months ago (2015-09-23 17:07:12 UTC) #3
Bill Hesse
lgtm https://codereview.chromium.org/1361163002/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/1361163002/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode172 tools/apps/update_homebrew/bin/update_homebrew.dart:172: bin.write_exec_script Dir["#{libexec}/bin/{pub,dart?*}"] Should we be replacing docgen with ...
5 years, 3 months ago (2015-09-23 17:10:11 UTC) #4
keertip
https://codereview.chromium.org/1361163002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/1361163002/diff/1/pkg/pkg.status#newcode17 pkg/pkg.status:17: [ $compiler != dartanalyzer && $compiler != dart2analyzer ] ...
5 years, 3 months ago (2015-09-23 17:24:55 UTC) #5
keertip
5 years, 3 months ago (2015-09-23 17:27:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
18b68f72909de0a705a12ad7b15dc9513c71f74b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698