Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1360823002: rev up dartdoc, markdown (Closed)

Created:
5 years, 3 months ago by keertip
Modified:
5 years, 3 months ago
Reviewers:
Bill Hesse, sethladd
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add flag for dartdoc runs" #

Total comments: 2

Patch Set 3 : split option into two args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/bots/dart_sdk.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
keertip
5 years, 3 months ago (2015-09-22 15:56:52 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1360823002/diff/20001/tools/bots/dart_sdk.py File tools/bots/dart_sdk.py (right): https://codereview.chromium.org/1360823002/diff/20001/tools/bots/dart_sdk.py#newcode44 tools/bots/dart_sdk.py:44: '--rel-canonical-prefix=https://api.dartlang.org/stable'], The other options are specified as two ...
5 years, 3 months ago (2015-09-22 16:05:15 UTC) #3
keertip
https://codereview.chromium.org/1360823002/diff/20001/tools/bots/dart_sdk.py File tools/bots/dart_sdk.py (right): https://codereview.chromium.org/1360823002/diff/20001/tools/bots/dart_sdk.py#newcode44 tools/bots/dart_sdk.py:44: '--rel-canonical-prefix=https://api.dartlang.org/stable'], On 2015/09/22 16:05:15, Bill Hesse wrote: > The ...
5 years, 3 months ago (2015-09-22 16:18:05 UTC) #4
keertip
5 years, 3 months ago (2015-09-22 16:45:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
895abbf8ddb28c3bd15d582e54ffce2a852bf117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698