Issue 136043003: workaround for strange bug in Chrome 32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136043003: workaround for strange bug in Chrome 32 (Closed)

Created:
6 years, 11 months ago by Jennifer Messerly

Modified:
6 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

workaround for strange bug in Chrome 32 Reflecting on Object's .declarations sometimes fails. In general we try to stop at Object in Polymer anyway, so for consistency I'm adding that workaround. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=31938

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	pkg/polymer/lib/src/declaration.dart	View	1	1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

this will address the red bots now that they are autoupdating to Chrome 32

6 years, 11 months ago (2014-01-17 23:13:08 UTC) #1

Jennifer Messerly

Committed patchset #2 manually as r31938 (presubmit successful).

6 years, 11 months ago (2014-01-17 23:22:33 UTC) #3

Jennifer Messerly

6 years, 11 months ago (2014-01-17 23:32:46 UTC) #4

Message was sent while issue was closed.

On 2014/01/17 23:21:05, blois wrote:
> Would be great to get a V8 bug, but lgtm.

Done: https://code.google.com/p/dart/issues/detail?id=16186

Expand Messages | Collapse Messages