Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1360283002: Silence pub --version tests (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
Bob Nystrom, rmacnak
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -35 lines) Patch
M tools/observatory_tool.py View 1 chunk +40 lines, -35 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 3 months ago (2015-09-23 21:12:21 UTC) #2
rmacnak
lgtm
5 years, 3 months ago (2015-09-23 21:15:00 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as dfe65284007c0df7949cc1db516822b606f23a9b (presubmit successful).
5 years, 3 months ago (2015-09-23 21:16:08 UTC) #4
Bob Nystrom
5 years, 2 months ago (2015-09-29 16:06:57 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1360283002/diff/1/tools/observatory_tool.py
File tools/observatory_tool.py (right):

https://codereview.chromium.org/1360283002/diff/1/tools/observatory_tool.py#n...
tools/observatory_tool.py:83: options.dart_executable is not None)
Drive-by! Instead of making an explicit null sink, I've used this before:

try:
  subprocess.check_output(args, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as error:
  ...

check_output consumes and returns stdout. If you redirect stderr to that, it
consumes all output. It raises a CalledProcessError error if the process exits
with a non-zero exit code.

Powered by Google App Engine
This is Rietveld 408576698