Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1360153005: Normalize constructor lookup. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M pkg/compiler/lib/src/resolution/constructors.dart View 4 chunks +27 lines, -9 lines 0 comments Download
A + tests/language/private_super_constructor_lib.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + tests/language/private_super_constructor_test.dart View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-09-23 17:07:45 UTC) #2
sigurdm
LGTM
5 years, 3 months ago (2015-09-24 07:39:53 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-09-24 08:07:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6ea60bdfcb78b47d86da052dbc32bc77b935bdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698