Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1360123003: only suggest rethrow inside catch block - fixes #24214 (Closed)

Created:
5 years, 2 months ago by danrubel
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

only suggest rethrow inside catch block - fixes #24214 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6e441f62e8423a45896b5e99f6985816008a81b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 4 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 7 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 2 months ago (2015-09-25 18:31:21 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-09-25 18:58:09 UTC) #3
danrubel
5 years, 2 months ago (2015-10-02 19:10:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e441f62e8423a45896b5e99f6985816008a81b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698