Let the embedder provide entry points to Dart_Precompile.

Let the embedder provide entry points to Dart_Precompile.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6021d060809a412cfcb36304ddcdff62efa7423

[rmacnak, 2015-09-23 18:12:59]

rmacnak@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-09-23 18:32:36]

lgtm

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/bin/main.cc#...
runtime/bin/main.cc:1284: { NULL, NULL, NULL }
Add comment: must be terminated with NULL entries.

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
File runtime/vm/precompiler.cc (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
runtime/vm/precompiler.cc:241: { NULL, NULL, NULL }
Add comment that the table must be terminated with NULL entries (or NULL entry
for library_uri)

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
File runtime/vm/precompiler.h (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
runtime/vm/precompiler.h:82: Dart_QualifiedFunctionName* embedder_entry_points);
Here and elsewhere:

use: Dart_QualifiedFunctionName embedder_entry_points[] to explicitly denote
that you are passing an array.

[rmacnak, 2015-09-23 20:17:35]

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/bin/main.cc#...
runtime/bin/main.cc:1284: { NULL, NULL, NULL }
On 2015/09/23 18:32:36, srdjan wrote:
> Add comment: must be terminated with NULL entries.

Done.

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
File runtime/vm/precompiler.cc (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
runtime/vm/precompiler.cc:241: { NULL, NULL, NULL }
On 2015/09/23 18:32:36, srdjan wrote:
> Add comment that the table must be terminated with NULL entries (or NULL entry
> for library_uri)

Done.

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
File runtime/vm/precompiler.h (right):

https://chromiumcodereview.appspot.com/1359963002/diff/1/runtime/vm/precompil...
runtime/vm/precompiler.h:82: Dart_QualifiedFunctionName* embedder_entry_points);
On 2015/09/23 18:32:36, srdjan wrote:
> Here and elsewhere:
> 
> use: Dart_QualifiedFunctionName embedder_entry_points[] to explicitly denote
> that you are passing an array.

Done.

[rmacnak, 2015-09-23 20:19:01]

Committed patchset #2 (id:20001) manually as
f6021d060809a412cfcb36304ddcdff62efa7423 (presubmit successful).