Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 13599005: Add JS implementation of LinkedHashMap. (Closed)

Created:
7 years, 8 months ago by kasperl
Modified:
7 years, 8 months ago
Reviewers:
erikcorry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add JS implementation of LinkedHashMap. R=erikcorry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21072

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review feedback. #

Patch Set 3 : Fix checked mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -111 lines) Patch
M runtime/lib/collection_patch.dart View 1 chunk +129 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart View 1 2 2 chunks +353 lines, -2 lines 0 comments Download
M sdk/lib/collection/linked_hash_map.dart View 1 chunk +14 lines, -109 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 8 months ago (2013-04-08 12:27:09 UTC) #1
erikcorry
LGTM As discussed offline there is an opportunity for refactoring to avoid code duplication once ...
7 years, 8 months ago (2013-04-08 13:15:52 UTC) #2
kasperl
Thanks for the review. Looking forward to getting started on the refactoring. https://codereview.chromium.org/13599005/diff/1/sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart File sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart ...
7 years, 8 months ago (2013-04-08 13:31:13 UTC) #3
kasperl
7 years, 8 months ago (2013-04-08 13:51:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698