Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1359293002: Move VERSION file location into top level variable (Closed)

Created:
5 years, 3 months ago by ricow1
Modified:
5 years, 3 months ago
Reviewers:
ahe, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move VERSION file location into top level variable This will allow for easier overwriting R=ahe@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bcfbfdfed360be6c7ea53888fe8ca677bf8bd0d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/utils.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 3 months ago (2015-09-23 06:37:03 UTC) #1
ahe
lgtm
5 years, 3 months ago (2015-09-23 06:38:52 UTC) #2
ricow1
5 years, 3 months ago (2015-09-23 06:45:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bcfbfdfed360be6c7ea53888fe8ca677bf8bd0d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698