Issue 1359113002: Use IndexContributor(s) in LocalIndex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359113002: Use IndexContributor(s) in LocalIndex. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use IndexContributor(s) in LocalIndex. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4aa6466ccb5dacb4cf2fe596edc9112d8d6d406c

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -466 lines)			Patch
D	pkg/analysis_server/lib/analysis/index/index_core.dart	View	1 chunk	+0 lines, -274 lines	0 comments	Download
D	pkg/analysis_server/lib/analysis/index/index_dart.dart	View	1 chunk	+0 lines, -41 lines	0 comments	Download
A +	pkg/analysis_server/lib/analysis/index_core.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/plugin/index.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/plugin/server_plugin.dart	View	4 chunks	+5 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index.dart	View	2 chunks	+5 lines, -15 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View	2 chunks	+8 lines, -63 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_store.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/indexable_element.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/local_index.dart	View	4 chunks	+24 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/local_memory_index.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/codec.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/split_store.dart	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/search/search_engine_internal.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis/update_content_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/local_index_test.dart	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/store/codec_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/move_file_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_library_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/search/hierarchy_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/search/search_engine_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 3 months ago (2015-09-23 15:17:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4aa6466ccb5dacb4cf2fe596edc9112d8d6d406c (presubmit successful).

Expand Messages | Collapse Messages