Issue 1358843002: Revert "dart2js cps: Change type tests to null tests when applicable."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358843002: Revert "dart2js cps: Change type tests to null tests when applicable." (Closed)

Created:
5 years, 3 months ago by asgerf

Modified:
5 years, 3 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js cps: Change type tests to null tests when applicable." This reverts commit 29dedfa97e3ff513d93b89c69c6b42b9746925d6. This triggers an assertion failure. BUG= Committed: https://github.com/dart-lang/sdk/commit/e97d32be50504c965b2f598f7f833b54be066fdf

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -21 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		2 chunks	+1 line, -21 lines	0 comments	Download

Total messages: 5 (1 generated)

asgerf

Committed patchset #1 (id:1) manually as e97d32be50504c965b2f598f7f833b54be066fdf (presubmit successful).

5 years, 3 months ago (2015-09-21 12:17:59 UTC) #4

Message was sent while issue was closed.

LGTM.