Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 13588005: Fix issue 9644: object stores become large pieces of code if heap tracing is turned on; jumps aroun… (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Fix issue 9644: object stores become large pieces of code if heap tracing is turned on; jumps around the the store must not use near labels. Committed: https://code.google.com/p/dart/source/detail?r=20902

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M runtime/vm/intrinsifier_ia32.cc View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
7 years, 8 months ago (2013-04-03 21:53:44 UTC) #1
siva
This needs to be addressed in x64 also? LGTM otherwise.
7 years, 8 months ago (2013-04-03 22:04:18 UTC) #2
srdjan
On 2013/04/03 22:04:18, siva wrote: > This needs to be addressed in x64 also? > ...
7 years, 8 months ago (2013-04-03 22:06:30 UTC) #3
srdjan
7 years, 8 months ago (2013-04-03 22:28:10 UTC) #4
srdjan
7 years, 8 months ago (2013-04-03 22:34:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r20902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698