Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 13587008: Updated VM stacktrace support (20898) with strndup impl. (Closed)

Created:
7 years, 8 months ago by Tom Ball
Modified:
7 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updated VM stacktrace support (20898) with platform- independent version of strndup. Committed: https://code.google.com/p/dart/source/detail?r=20936

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -47 lines) Patch
M runtime/platform/c99_support_win.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 5 chunks +22 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 4 chunks +178 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Ball
This CL is the same as 20898, except I replaced use of strndup, which isn't ...
7 years, 8 months ago (2013-04-03 23:11:39 UTC) #1
Tom Ball
The new Strndup is in isolate.cc.
7 years, 8 months ago (2013-04-03 23:12:04 UTC) #2
siva
lgtm
7 years, 8 months ago (2013-04-04 00:04:15 UTC) #3
siva
Actually a better solution might be to add your new strndup implementation to platform/c99_support_win.h and ...
7 years, 8 months ago (2013-04-04 00:42:59 UTC) #4
Tom Ball
On 2013/04/04 00:42:59, siva wrote: > Actually a better solution might be to add your ...
7 years, 8 months ago (2013-04-04 18:48:04 UTC) #5
Tom Ball
7 years, 8 months ago (2013-04-04 18:48:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698