Issue 13584006: Turn off FindCodeObject for simmips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13584006: Turn off FindCodeObject for simmips. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Turn off FindCodeObject for simmips. I hadn't run it with type checks, and so I've got some more work to do on it. Committed: https://code.google.com/p/dart/source/detail?r=20896

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

Committed patchset #1 manually as r20896 (presubmit successful).

7 years, 8 months ago (2013-04-03 21:58:49 UTC) #2

regis

7 years, 8 months ago (2013-04-03 22:20:11 UTC) #3

Message was sent while issue was closed.

LGTM with comment for next cl.

https://codereview.chromium.org/13584006/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/13584006/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:75: cc/FindCodeObject: Skip
For next cl: skip only in checked mode, since it works in production mode:

[ $arch == simmips && $checked ]
cc/FindCodeObject: Skip

Expand Messages | Collapse Messages