dart2js: fix nondeterministic output of type metadata.

dart2js: fix nondeterministic output of type metadata.

Use consistent hashcode for deferred index into metadata.
Slightly nicer names for type constants in non-minified mode.

C.Type_k8F -->  C.Type_String_k8F

BUG= http://dartbug.com/24391
R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/4cb72d2baf4dfa17507e3f259414ac9d71aea7a9

Committed: https://github.com/dart-lang/sdk/commit/8852bf9e14683b15607f9df42d69bd58acf873bc

[sra1, 2015-09-23 02:31:37]

Patchset #1 (id:1) has been deleted

[sra1, 2015-09-23 02:33:46]

sra@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2015-09-23 17:36:25]

lgtm

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/namer.dart:1846: int
visitSynthetic(SyntheticConstantValue constant, [_]) {
this would be clearer if it was:
if (constant.kind != SytheticConstantKind.TYPEVARIABLEREFERENCE) {
  compiler.internalError(...);
}
// These contain ...
return 0;

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/namer.dart:1851: // resolve to integer indexes,
they always part of a larger constant.
nit: they always -> they're always

[sra1, 2015-09-23 22:52:05]

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/namer.dart:1846: int
visitSynthetic(SyntheticConstantValue constant, [_]) {
On 2015/09/23 17:36:25, Harry Terkelsen wrote:
> this would be clearer if it was:
> if (constant.kind != SytheticConstantKind.TYPEVARIABLEREFERENCE) {
>   compiler.internalError(...);
> }
> // These contain ...
> return 0;

I'd like to keep it as-is since other visitSynthetic methods have a switch with
multiple cases.

https://codereview.chromium.org/1358363002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/namer.dart:1851: // resolve to integer indexes,
they always part of a larger constant.
On 2015/09/23 17:36:25, Harry Terkelsen wrote:
> nit: they always -> they're always

Done.

[sra1, 2015-09-23 22:53:06]

Committed patchset #2 (id:10002) manually as
4cb72d2baf4dfa17507e3f259414ac9d71aea7a9 (presubmit successful).

[sra1, 2015-09-24 00:08:38]

Committed patchset #4 (id:70001) manually as
8852bf9e14683b15607f9df42d69bd58acf873bc (presubmit successful).