Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135803003: Translate index. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Translate index. No tests yet. I'll need some time to find out how to translate Mockito based tests to Dart. R=brianwilkerson@google.com, devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31729

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3150 lines, -172 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolver.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/IndexContributor.java View 4 chunks +0 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/MemoryIndexStoreImpl.java View 7 chunks +27 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/operation/OperationProcessor.java View 4 chunks +16 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/operation/OperationQueue.java View 6 chunks +30 lines, -19 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 2 chunks +10 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 6 chunks +159 lines, -0 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java View 4 chunks +33 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/Bindings.java View 1 chunk +3 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 1 chunk +40 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/GuavaSemanticProcessorTest.java View 7 chunks +25 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +6 lines, -6 lines 0 comments Download
A pkg/analyzer/lib/src/generated/index.dart View 1 chunk +2683 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 47 chunks +56 lines, -56 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 12 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 11 months ago (2014-01-12 01:54:38 UTC) #1
devoncarew
Awesome! Thanks much. I'll leave the review to Brian, but two things jump out at ...
6 years, 11 months ago (2014-01-12 05:17:28 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/135803003/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java (right): https://codereview.chromium.org/135803003/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java#newcode854 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java:854: // XXX Remove?
6 years, 11 months ago (2014-01-12 18:58:57 UTC) #3
scheglov
Committed patchset #1 manually as r31729 (presubmit successful).
6 years, 11 months ago (2014-01-13 01:12:33 UTC) #4
scheglov
6 years, 11 months ago (2014-01-13 05:53:26 UTC) #5
Message was sent while issue was closed. 
On 2014/01/12 05:17:28, devoncarew wrote:
> Awesome! Thanks much. I'll leave the review to Brian, but two things jump out
at
> me (not something to solve for this CL):
> 
> - the generated files should probably have our standard copyright header
> - it would be nice if the generated anonymous inner classes somehow had stable
> names. This would reduce the amount of review diffs. Not sure how stable names
> would be achieved though -

See
1. https://codereview.chromium.org/136143002/
2. https://codereview.chromium.org/136223002/

Powered by Google App Engine
This is Rietveld 408576698