Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 13575002: Mark CallLeafRuntimeStubCode as failing on Mips/Mac OS X. (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
Reviewers:
zra, regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark CallLeafRuntimeStubCode as failing on Mips/Mac OS X. Added some cleanups. Committed: https://code.google.com/p/dart/source/detail?r=20885

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
Please take a look at simmips failure on Mac OS X.
7 years, 8 months ago (2013-04-03 19:01:42 UTC) #1
regis
LGTM Thanks for the report. Zach will have a look.
7 years, 8 months ago (2013-04-03 19:41:45 UTC) #2
srdjan
7 years, 8 months ago (2013-04-03 19:42:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698