Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 13571003: Re-try of Flipping the direction of WheelEvent.deltaX/Y to follow standards (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Resubmit of: Flipping the direction of WheelEvent.deltaX/Y to follow standards We're trying to follow the W3C spec for WheelEvent, but the standard has the direction in the opposite direction from what we have it now. BUG=6215 BUG= Committed: https://code.google.com/p/dart/source/detail?r=20946

Patch Set 1 #

Patch Set 2 : Fixes for Dartium and Firefox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -18 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +30 lines, -7 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +23 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 9 chunks +54 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 8 months ago (2013-04-03 19:36:56 UTC) #1
Emily Fortuna
lgtm!
7 years, 8 months ago (2013-04-03 19:52:57 UTC) #2
blois
7 years, 8 months ago (2013-04-05 00:44:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698