Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1357003002: rename inherited_computer to inherited_contributor (TBR) (Closed)

Created:
5 years, 3 months ago by danrubel
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rename inherited_computer to inherited_contributor (TBR) Committed: https://github.com/dart-lang/sdk/commit/9ad1bf1f0e6bccb969839728c081ca0956c4f012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -159 lines) Patch
D pkg/analysis_server/lib/src/services/completion/inherited_computer.dart View 1 chunk +0 lines, -160 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/inherited_contributor.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
danrubel
Committed patchset #1 (id:1) manually as 9ad1bf1f0e6bccb969839728c081ca0956c4f012 (presubmit successful).
5 years, 3 months ago (2015-09-18 19:57:04 UTC) #1
Brian Wilkerson
5 years, 3 months ago (2015-09-18 19:59:05 UTC) #3
Message was sent while issue was closed.
LGTM, but I made and git committed these changes. Why didn't they get included
in the dcommit?

Powered by Google App Engine
This is Rietveld 408576698