Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 135653009: Fix package docnames for select return types, and some more docgen refactoring. (Closed)

Created:
6 years, 11 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix package docnames for select return types, and some more docgen refactoring. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=32129

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -187 lines) Patch
M pkg/docgen/lib/docgen.dart View 35 chunks +212 lines, -184 lines 0 comments Download
M pkg/docgen/test/multi_library_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
6 years, 11 months ago (2014-01-17 23:22:38 UTC) #1
Alan Knight
lgtm
6 years, 11 months ago (2014-01-28 01:13:22 UTC) #2
Emily Fortuna
6 years, 10 months ago (2014-01-29 18:43:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698