Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 135653008: New analyzer snapshot. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer snapshot. Extracts SdkLibrariesReader_LibraryBuilder into sdk.dart library. https://code.google.com/p/dart/issues/detail?id=14791 R=brianwilkerson@google.com, devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31939

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -124 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +4 lines, -0 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 2 chunks +17 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 4 chunks +22 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 29 chunks +134 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +82 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +0 lines, -102 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 11 months ago (2014-01-17 22:56:57 UTC) #1
devoncarew
lgtm Thanks!
6 years, 11 months ago (2014-01-17 22:59:06 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/135653008/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart (right): https://codereview.chromium.org/135653008/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart#newcode11 editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:11: return currentTimeMillis() * 1000000; :-(
6 years, 11 months ago (2014-01-17 23:43:22 UTC) #3
scheglov
6 years, 11 months ago (2014-01-18 00:05:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698