Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 13565005: Revert r20952, r20953, r20954 (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert r20952, r20953, r20954 Too many failures due to conflicting top level sleep methods. TBR=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/process.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M runtime/bin/process_patch.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/utils_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/utils_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/utils_macos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/utils_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/io/process.dart View 3 chunks +1 line, -12 lines 0 comments Download
D tests/standalone/io/sleep_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-05 10:06:37 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r20955 (presubmit successful).
7 years, 8 months ago (2013-04-05 10:07:14 UTC) #2
Mads Ager (google)
7 years, 8 months ago (2013-04-05 10:11:58 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698