Issue 1355853005: Limit cache invalidation by the updated source bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1355853005: Limit cache invalidation by the updated source bounds. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Limit cache invalidation by the updated source bounds. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a25cc8129a88c9c826c3bf3d361de961b1e07905

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	pkg/analyzer/lib/plugin/task.dart	View		1 chunk	+6 lines, -0 lines	1 comment	Download
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1355853005/diff/1/pkg/analyzer/lib/plugin/task.dart File pkg/analyzer/lib/plugin/task.dart (right): https://codereview.chromium.org/1355853005/diff/1/pkg/analyzer/lib/plugin/task.dart#newcode51 pkg/analyzer/lib/plugin/task.dart:51: * by performance reasons. "by" --> "for"

5 years, 3 months ago (2015-09-18 22:15:30 UTC) #2

scheglov

5 years, 3 months ago (2015-09-19 01:11:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a25cc8129a88c9c826c3bf3d361de961b1e07905 (presubmit successful).

Expand Messages | Collapse Messages