Make type system changes backwards compatible

Make type system changes backwards compatible

This CL eliminates the additional typeSystem arguments added to the API by https://codereview.chromium.org/1329743005/  wherever possible, instead projecting out the typeSystem from the context as available.  Where not possible, the additional argument is made optional, defaulting to the standard TypeSystemImpl.  I believe that the result of this should be backwards compatible for clients (but not implementors) of the API.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/f912eabcbfc9c2fcbc51812d65fe85a8d1f97715

[Leaf, 2015-09-18 04:04:44]

leafp@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Paul Berry, 2015-09-18 05:19:25]

lgtm.  Thanks for taking care of this.  Sorry we failed to notice these backward
compatibility issues during the previous code review.

https://codereview.chromium.org/1355773002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1355773002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:890: this._typeProvider,
this.declaredVariables) {
Nit: how about this instead:

ConstantVerifier(this._errorReporter, LibraryElement currentLibrary,
    this._typeProvider, this.declaredVariables)
  : _currentLibrary = currentLibrary,
    _typeSystem = currentLibrary.context.typeSystem {
  ...
}

That way we can keep the "final" modifier on the declaration of the _typeSystem
field.

[Brian Wilkerson, 2015-09-18 13:52:44]

LGTM

[vsm, 2015-09-18 15:40:28]

On 2015/09/18 13:52:44, Brian Wilkerson wrote:
> LGTM

Thanks, Leaf.  I patched this in locally - it's fixing the breakage I was seeing
with dartanalyzer --strong.

[Leaf, 2015-09-18 16:59:04]

https://codereview.chromium.org/1355773002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1355773002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:890: this._typeProvider,
this.declaredVariables) {
On 2015/09/18 05:19:25, Paul Berry wrote:
> Nit: how about this instead:
> 
> ConstantVerifier(this._errorReporter, LibraryElement currentLibrary,
>     this._typeProvider, this.declaredVariables)
>   : _currentLibrary = currentLibrary,
>     _typeSystem = currentLibrary.context.typeSystem {
>   ...
> }
> 
> That way we can keep the "final" modifier on the declaration of the
_typeSystem
> field.

Done.

[Leaf, 2015-09-18 16:59:15]

Committed patchset #2 (id:20001) manually as
f912eabcbfc9c2fcbc51812d65fe85a8d1f97715 (presubmit successful).