Issue 135553005: Fix issue 16592: Do not attempt to merge operations that do not have uses, otherwise we add force u…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135553005: Fix issue 16592: Do not attempt to merge operations that do not have uses, otherwise we add force u… (Closed)

Created:
6 years, 10 months ago by srdjan

Modified:
6 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 16592: Do not attempt to merge operations that do not have uses, otherwise we add force uses to them (temporary array to hold two results) and the graph verification fails(no SSA temp but has uses). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32381

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -2 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	4 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/language/arithmetic_test.dart	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

6 years, 10 months ago (2014-02-06 19:55:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32381 (presubmit successful).

Expand Messages | Collapse Messages