Issue 1355503004: Fix for updating HINTS during incremental resolution with TM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1355503004: Fix for updating HINTS during incremental resolution with TM. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for updating HINTS during incremental resolution with TM. The key change is not updating LIBRARY_UNIT_ERRORS in IncrementalResolver. Otherwise it becomes VALID and we don't recompute it, so don't recompute HINTS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fcb0c319daa1069e9b122a2d99d1aa7bcd868147

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -33 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View	3 chunks	+35 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	6 chunks	+12 lines, -28 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/context/cache_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 3 months ago (2015-09-18 20:41:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fcb0c319daa1069e9b122a2d99d1aa7bcd868147 (presubmit successful).