Issue 1355393003: JS inline handles -dynamic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1355393003: JS inline handles -dynamic (Closed)

Created:
5 years, 3 months ago by Leaf

Modified:
5 years, 3 months ago

Reviewers:
vsm, scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

This adds support for a DDC special case of inline JS. It also addresses an issue from an earlier CL, makes some readability improvements, and eliminates some now-redundant TODOs. BUG= R=scheglov@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/ff86501c8587f2369ec05fc73af855e37867728b

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -15 lines)			Patch
	M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	1	7 chunks	+20 lines, -15 lines	0 comments	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Leaf

5 years, 3 months ago (2015-09-23 15:58:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ff86501c8587f2369ec05fc73af855e37867728b (presubmit successful).