Issue 1355223002: Change Hash subclasses to be Converters.

Issue 1355223002: Change Hash subclasses to be Converters. (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/crypto.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Change Hash subclasses to be Converters. To make it easier to migrate packages to the new API, I plan to release one more 0.9.2 release with a bunch of new APIs but no old functionality removed. A bunch of stuff will be deprecated, though, and it will be immediately followed by a 1.0.0 release that removes all the deprecated APIs. R=rnystrom@google.com Committed: https://github.com/dart-lang/crypto/commit/9fe896f5c8bbefa917fcbab1ea8518e1d63ebd11

Patch Set 1 #

Patch Set 2 : Add a type annotation. #

Patch Set 3 : Add docs #

Total comments: 6

Patch Set 4 : Code review changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -243 lines)			Patch
M	CHANGELOG.md	View	1 2 3	1 chunk	+19 lines, -5 lines	0 comments	Download
M	lib/src/digest.dart	View		3 chunks	+5 lines, -6 lines	0 comments	Download
A	lib/src/digest_sink.dart	View	1 2 3	1 chunk	+29 lines, -0 lines	0 comments	Download
M	lib/src/hash.dart	View	1 2	1 chunk	+48 lines, -17 lines	0 comments	Download
D	lib/src/hash_base.dart	View		1 chunk	+0 lines, -137 lines	0 comments	Download
A +	lib/src/hash_sink.dart	View	1 2 3	3 chunks	+11 lines, -8 lines	0 comments	Download
M	lib/src/hmac.dart	View		5 chunks	+15 lines, -14 lines	0 comments	Download
M	lib/src/md5.dart	View	1 2 3	2 chunks	+28 lines, -8 lines	0 comments	Download
M	lib/src/sha1.dart	View	1 2 3	3 chunks	+25 lines, -9 lines	0 comments	Download
M	lib/src/sha256.dart	View	1 2 3	4 chunks	+25 lines, -9 lines	0 comments	Download
M	test/sha1_test.dart	View		1 chunk	+30 lines, -15 lines	0 comments	Download
M	test/sha256_test.dart	View		2 chunks	+30 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/1355223002/diff/40001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1355223002/diff/40001/CHANGELOG.md#newcode10 CHANGELOG.md:10: to convert " to convert..."? https://codereview.chromium.org/1355223002/diff/40001/lib/src/digest_sink.dart File lib/src/digest_sink.dart ...

5 years, 3 months ago (2015-09-22 17:47:31 UTC) #2

nweiz

Committed patchset #4 (id:60001) manually as 9fe896f5c8bbefa917fcbab1ea8518e1d63ebd11 (presubmit successful).

5 years, 3 months ago (2015-09-22 21:34:31 UTC) #4

nweiz

5 years, 3 months ago (2015-09-22 21:37:34 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1355223002/diff/40001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1355223002/diff/40001/CHANGELOG.md#newcode10
CHANGELOG.md:10: to convert
On 2015/09/22 17:47:31, Bob Nystrom wrote:
> " to convert..."?

Done.

https://codereview.chromium.org/1355223002/diff/40001/lib/src/digest_sink.dart
File lib/src/digest_sink.dart (right):

https://codereview.chromium.org/1355223002/diff/40001/lib/src/digest_sink.dar...
lib/src/digest_sink.dart:18: void add(Digest value) {
On 2015/09/22 17:47:31, Bob Nystrom wrote:
> Document that this can only be called once.

Done.

https://codereview.chromium.org/1355223002/diff/40001/lib/src/hash_sink.dart
File lib/src/hash_sink.dart (right):

https://codereview.chromium.org/1355223002/diff/40001/lib/src/hash_sink.dart#...
lib/src/hash_sink.dart:15: /// A base class for [Hash] implementations.
On 2015/09/22 17:47:31, Bob Nystrom wrote:
> Is this correct?

Not anymore!

Expand Messages | Collapse Messages