Issue 13547002: Make type_cast test less fragile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13547002: Make type_cast test less fragile. (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, floitsch, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make type_cast test less fragile. Committed: https://code.google.com/p/dart/source/detail?r=20877

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -21 lines)			Patch
	M	tests/language/type_cast_vm_test.dart	View	1 2	5 chunks	+7 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with questions https://codereview.chromium.org/13547002/diff/3001/tests/language/type_cast_vm_test.dart File tests/language/type_cast_vm_test.dart (right): https://codereview.chromium.org/13547002/diff/3001/tests/language/type_cast_vm_test.dart#newcode39 tests/language/type_cast_vm_test.dart:39: Expect.equals(1, error.column); Why don't you use ...

7 years, 8 months ago (2013-04-03 16:20:59 UTC) #2

srdjan

Committed patchset #3 manually as r20877 (presubmit successful).

7 years, 8 months ago (2013-04-03 17:19:42 UTC) #3

srdjan

7 years, 8 months ago (2013-04-12 23:01:41 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13547002/diff/3001/tests/language/type_cast_v...
File tests/language/type_cast_vm_test.dart (right):

https://codereview.chromium.org/13547002/diff/3001/tests/language/type_cast_v...
tests/language/type_cast_vm_test.dart:39: Expect.equals(1, error.column);
On 2013/04/03 16:21:00, regis wrote:
> Why don't you use checkTopFunction here as you do below?

Changed to use checkTopFunction instead

https://codereview.chromium.org/13547002/diff/3001/tests/language/type_cast_v...
tests/language/type_cast_vm_test.dart:80: Expect.equals(1880, error.line);
On 2013/04/03 16:21:00, regis wrote:
> Why is this one not an issue?

It is an issue, you are correct. Changed to checkTopFunction.

Expand Messages | Collapse Messages

Issue 13547002: Make type_cast test less fragile. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages