Issue 1354463003: dart2js: clean up setRuntimeType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1354463003: dart2js: clean up setRuntimeType (Closed)

Created:
5 years, 3 months ago by karlklose

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: clean up setRuntimeType We do not call setRuntimeType on the result of factories - only of generative constructors, which do not return null. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/bd331519c6c3dfe61de471cc8ac7262af6e8821b

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/js_rti.dart	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

karlklose

5 years, 3 months ago (2015-09-18 09:33:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bd331519c6c3dfe61de471cc8ac7262af6e8821b (presubmit successful).