Issue 1353913002: Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1353913002: Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339 (Closed)

Created:
5 years, 3 months ago by danrubel

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339 I will convert CompletionSorter to use the new completion API in a subsequent CL. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b96b1cfc5d803d1a060e08f19bfb0a8d1effd590

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -25 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart	View	3 chunks	+6 lines, -18 lines	0 comments	Download
A	pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart	View	5 chunks	+15 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	3 chunks	+35 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/mock_sdk.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

danrubel

5 years, 3 months ago (2015-09-17 18:59:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b96b1cfc5d803d1a060e08f19bfb0a8d1effd590 (presubmit successful).