Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 13539003: pkg/unittest: handling of runTests being called without any tests (Closed)

Created:
7 years, 8 months ago by kevmoo-old
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: handling of runTests being called without any tests Before: error trying to call config.onStart without initialization Now: unittest run completes with error (No tests run) Committed: https://code.google.com/p/dart/source/detail?r=20915

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M pkg/unittest/lib/unittest.dart View 3 chunks +6 lines, -1 line 0 comments Download
M pkg/unittest/test/unittest_test.dart View 1 6 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
PTAL
7 years, 8 months ago (2013-04-03 14:57:40 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/13539003/diff/1/pkg/unittest/test/unittest_test.dart File pkg/unittest/test/unittest_test.dart (right): https://codereview.chromium.org/13539003/diff/1/pkg/unittest/test/unittest_test.dart#newcode73 pkg/unittest/test/unittest_test.dart:73: var testConfig= new TestConfiguration(sendport); while you are here, ...
7 years, 8 months ago (2013-04-04 00:05:24 UTC) #2
kevmoo-old
7 years, 8 months ago (2013-04-04 13:13:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698