Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353843002: dart2js cps: Support sync* and yield. (Closed)

Created:
5 years, 3 months ago by karlklose
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -346 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 4 chunks +24 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 2 chunks +13 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 5 chunks +28 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -26 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +5 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 6 chunks +42 lines, -70 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +6 lines, -222 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
karlklose
5 years, 3 months ago (2015-09-17 12:39:39 UTC) #1
karlklose
On 2015/09/17 12:39:39, karlklose wrote: Ping.
5 years, 3 months ago (2015-09-21 09:04:19 UTC) #2
asgerf
Drive-by LGTM.
5 years, 3 months ago (2015-09-21 11:51:03 UTC) #4
karlklose
5 years, 2 months ago (2015-09-23 09:01:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e28e578731bcc88f0c287b59900c07d24494a759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698