Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353373002: Fix obsolete gsutil command in scripts. Delete editor signing script. (Closed)

Created:
5 years, 3 months ago by Bill Hesse
Modified:
5 years, 3 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix obsolete gsutil command in scripts. Delete editor signing script. BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/eee0e77207fc58516219a4b0cc5d59ea0eab1c0d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -289 lines) Patch
M tools/bots/cross-vm.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/dartium/upload_steps.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/signing_script.py View 1 chunk +0 lines, -286 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
5 years, 3 months ago (2015-09-21 10:05:44 UTC) #2
ricow1
https://codereview.chromium.org/1353373002/diff/1/tools/bots/cross-vm.py File tools/bots/cross-vm.py (right): https://codereview.chromium.org/1353373002/diff/1/tools/bots/cross-vm.py#newcode54 tools/bots/cross-vm.py:54: run([GSUTIL, 'cp', tarball, uri]) cp -a public-read?
5 years, 3 months ago (2015-09-21 10:13:25 UTC) #3
ricow1
and lgtm
5 years, 3 months ago (2015-09-21 10:14:55 UTC) #4
Bill Hesse
https://codereview.chromium.org/1353373002/diff/1/tools/bots/cross-vm.py File tools/bots/cross-vm.py (right): https://codereview.chromium.org/1353373002/diff/1/tools/bots/cross-vm.py#newcode54 tools/bots/cross-vm.py:54: run([GSUTIL, 'cp', tarball, uri]) On 2015/09/21 10:13:25, ricow1 wrote: ...
5 years, 3 months ago (2015-09-21 10:18:29 UTC) #5
Bill Hesse
5 years, 3 months ago (2015-09-21 10:18:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
eee0e77207fc58516219a4b0cc5d59ea0eab1c0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698