Issue 13533016: Add line table command to debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13533016: Add line table command to debugger (Closed)

Created:
7 years, 8 months ago by hausner

Modified:
7 years, 8 months ago

Reviewers:
Tom Ball

CC:
reviews_dartlang.org, Ivan Posva, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add line table command to debugger New command returns token information of a script. This will enable the editor/debugger to translate token offsets to line numbers. Committed: https://code.google.com/p/dart/source/detail?r=21009

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -1 line)			Patch
M	runtime/bin/dbg_message.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/dbg_message.cc	View	1 2 3 4	2 chunks	+48 lines, -0 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1 2 3 4	1 chunk	+22 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2 3 4	1 chunk	+51 lines, -0 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2 3 4	4 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Ball

lgtm Your comment about potentially skipping keywords from line table sounds good, too.

7 years, 8 months ago (2013-04-05 16:51:06 UTC) #2

hausner

7 years, 8 months ago (2013-04-05 23:45:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r21009 (presubmit successful).

Expand Messages | Collapse Messages