Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1353013003: Add fine-grained logging for long running transformers. (Closed)

Created:
5 years, 3 months ago by tjblasi
Modified:
5 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/barback.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add fine-grained logging for long running transformers. Every 10 seconds, log a message detailing the duration of the transformer and any secondary assets it is waiting for. These messages are made visible by the `--verbose` or `--verbosity=all` flags. BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/barback/commit/db6db0c7b340da7689d85f2e2af7cbf6fc6ca2aa

Patch Set 1 #

Patch Set 2 : Fix missing negation #

Patch Set 3 : Formatting... #

Patch Set 4 : Changelog entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/graph/transform_node.dart View 1 2 5 chunks +43 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tjblasi
Thanks
5 years, 3 months ago (2015-09-17 21:56:50 UTC) #2
nweiz
Can you add a CHANGELOG entry?
5 years, 3 months ago (2015-09-17 23:00:31 UTC) #3
tjblasi
Sure, CHANGELOG entry added
5 years, 3 months ago (2015-09-17 23:04:18 UTC) #4
nweiz
lgtm
5 years, 3 months ago (2015-09-17 23:11:08 UTC) #5
tjblasi
5 years, 3 months ago (2015-09-18 00:00:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
db6db0c7b340da7689d85f2e2af7cbf6fc6ca2aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698