Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 13530003: Deprecate Collection class. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Deprecate Collection class. Committed: https://code.google.com/p/dart/source/detail?r=20870

Patch Set 1 #

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/async/collection_sink.dart View 1 chunk +5 lines, -1 line 0 comments Download
M sdk/lib/core/collection.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
Running tests now, but I don't expect a lot of breakage.
7 years, 8 months ago (2013-04-03 12:56:05 UTC) #1
Lasse Reichstein Nielsen
STV.
7 years, 8 months ago (2013-04-03 14:27:16 UTC) #2
Lasse Reichstein Nielsen
We might want to reassure users that "add" and "remove" are not going away from ...
7 years, 8 months ago (2013-04-03 14:29:29 UTC) #3
floitsch
Needed to change some Editor tests.
7 years, 8 months ago (2013-04-03 14:44:51 UTC) #4
danrubel
Good by me. Added Konstantin to review DartC changes.
7 years, 8 months ago (2013-04-03 15:04:09 UTC) #5
floitsch
Committed patchset #2 manually as r20870 (presubmit successful).
7 years, 8 months ago (2013-04-03 16:08:58 UTC) #6
scheglov
7 years, 8 months ago (2013-04-03 16:17:52 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698