Issue 13529021: Fix guarded_cid handling: add field to list of guarded_field at LoadField creation time.

Issue 13529021: Fix guarded_cid handling: add field to list of guarded_field at LoadField creation time. (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix guarded_cid handling: add field to list of guarded_field at LoadField creation time. Committed: https://code.google.com/p/dart/source/detail?r=20998

Patch Set 4 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -69 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2 3	3 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 2 3	1 chunk	+0 lines, -36 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2 3	5 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	3 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

LGTM! https://codereview.chromium.org/13529021/diff/1010/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/13529021/diff/1010/runtime/vm/compiler.cc#newcode170 runtime/vm/compiler.cc:170: GrowableArray<Field*> guarded_fields(10); Please move a comment that was ...

7 years, 8 months ago (2013-04-05 19:35:00 UTC) #2

srdjan

https://codereview.chromium.org/13529021/diff/1010/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/13529021/diff/1010/runtime/vm/compiler.cc#newcode170 runtime/vm/compiler.cc:170: GrowableArray<Field*> guarded_fields(10); On 2013/04/05 19:35:00, Vyacheslav Egorov (Google) wrote: ...

7 years, 8 months ago (2013-04-05 20:41:24 UTC) #3

srdjan

7 years, 8 months ago (2013-04-05 21:01:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r20998 (presubmit successful).

Expand Messages | Collapse Messages