Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1352843002: Highlight library identifiers as LIBRARY_NAME. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-17 15:13:36 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-17 16:07:19 UTC) #2
scheglov
5 years, 3 months ago (2015-09-17 16:24:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d71bda7c05f408c10735dcb9a7678f725548d7ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698