Issue 13528004: Remove addLast from List.

Issue 13528004: Remove addLast from List. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove addLast from List. The List.addLast method has been deprecated for quite a while. A recent change removed it from the interface, but left the implementation in place (which caused some errors from the analyzer). This removes it completely. Committed: https://code.google.com/p/dart/source/detail?r=20857

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove typo #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -476 lines)			Patch
M	pkg/serialization/lib/src/serialization_rule.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/array.dart	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/lib/typeddata.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/tests/vm/dart/byte_array_optimized_test.dart	View		20 chunks	+0 lines, -40 lines	0 comments	Download
M	runtime/tests/vm/dart/byte_array_test.dart	View		21 chunks	+0 lines, -42 lines	0 comments	Download
M	samples/swarm/swarm_ui_lib/observable/observable.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/_collection_dev/list.dart	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		35 chunks	+0 lines, -137 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		35 chunks	+0 lines, -137 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		6 chunks	+0 lines, -24 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		6 chunks	+0 lines, -24 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	tests/html/node_test.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/dom/src/WrappedList.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	tools/dom/templates/immutable_list_mixin.darttemplate	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/13528004/diff/1/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (right): https://codereview.chromium.org/13528004/diff/1/tests/co19/co19-compiler.status#newcode163 tests/co19/co19-compiler.status:163: LibTest/core/Date/timeZoneOffset_A01_t01: Fail # Renamed Date to DateTime (issue ...

7 years, 8 months ago (2013-04-03 12:42:56 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #2 manually as r20857 (presubmit successful).

7 years, 8 months ago (2013-04-03 12:52:46 UTC) #3

srdjan

7 years, 8 months ago (2013-04-06 00:02:58 UTC) #4

Message was sent while issue was closed.

On 2013/04/03 12:52:46, Lasse Reichstein Nielsen wrote:
> Committed patchset #2 manually as r20857 (presubmit successful


This CL seems to have broken VanillaCompileDart2JS:

http://108.170.219.0:8080/Benchmark?benchmark=VanillaCompileDart2JS#targets=dart

Expand Messages | Collapse Messages