Issue 13527004: Add comments to the synchronous file methods stating that they throw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13527004: Add comments to the synchronous file methods stating that they throw (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add comments to the synchronous file methods stating that they throw exceptions on errors. Fix a couple of bugs in readSync implementation. R=sgjesse@google.com BUG=dartbug.com/7779 Committed: https://code.google.com/p/dart/source/detail?r=20858

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -9 lines)			Patch
M	sdk/lib/io/file.dart	View	26 chunks	+55 lines, -8 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	2 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

7 years, 8 months ago (2013-04-03 12:59:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20858 (presubmit successful).