Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 13527003: Make `this` available in closures if a type variable is used as expression. (Closed)

Created:
7 years, 8 months ago by karlklose
Modified:
7 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make `this` available in closures if a type variable is used as expression. Committed: https://code.google.com/p/dart/source/detail?r=20950

Patch Set 1 #

Patch Set 2 : Rename test. #

Patch Set 3 : Add null check and test status for dart2dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + tests/language/closure_type_variable_test.dart View 1 1 chunk +7 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 8 months ago (2013-04-04 14:06:12 UTC) #1
floitsch
LGTM.
7 years, 8 months ago (2013-04-04 17:36:08 UTC) #2
karlklose
7 years, 8 months ago (2013-04-05 08:32:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698