Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1352533002: Enqueue superclasses instead of supertypes. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
karlklose, herhut, sra1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Rebase + Skip UNUSED_ messages in message_kind_test #

Patch Set 4 : Unify native behavior processing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -85 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 2 3 2 chunks +21 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 2 3 2 chunks +15 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 3 3 chunks +16 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 2 chunks +31 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 5 chunks +40 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 6 chunks +42 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/interceptors.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_array.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/array_static_intercept_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Johnni Winther
Main changes in enqueue.dart, universe.dart and world.dart
5 years, 3 months ago (2015-09-16 18:22:53 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1352533002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/1352533002/diff/1/pkg/compiler/lib/src/world.dart#newcode326 pkg/compiler/lib/src/world.dart:326: void addLiveUse(MixinApplicationElement mixinApplication) { Consider push this local ...
5 years, 3 months ago (2015-09-17 10:42:38 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as a118955a2b8b2cda45972b32f228eaad623a1328 (presubmit successful).
5 years, 3 months ago (2015-09-17 11:28:42 UTC) #4
Johnni Winther
https://codereview.chromium.org/1352533002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/1352533002/diff/1/pkg/compiler/lib/src/world.dart#newcode326 pkg/compiler/lib/src/world.dart:326: void addLiveUse(MixinApplicationElement mixinApplication) { On 2015/09/17 10:42:38, karlklose wrote: ...
5 years, 3 months ago (2015-09-17 12:56:40 UTC) #5
Johnni Winther
@sra1: Could you take a look at the last patch? (The changes in elements/* are ...
5 years, 2 months ago (2015-09-23 17:53:51 UTC) #7
Johnni Winther
5 years, 2 months ago (2015-09-24 08:27:26 UTC) #9
herhut
I agree that the handling of behaviour in HForeign should go through the same code ...
5 years, 2 months ago (2015-09-24 08:43:46 UTC) #10
herhut
I agree that the handling of behaviour in HForeign should go through the same code ...
5 years, 2 months ago (2015-09-24 08:43:48 UTC) #11
Johnni Winther
5 years, 2 months ago (2015-09-24 09:20:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
f794df713bd1cd459951b18479589e26a2dc4407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698