Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1352493002: Automatically set correct Observatory analytics version (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Automatically set correct Observatory analytics version R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/eb3fe782007ed5b51969cddcbd937f151515386f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/observatory/lib/src/app/analytics.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/observatory_tool.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 3 months ago (2015-09-16 17:21:34 UTC) #2
turnidge
lgtm
5 years, 3 months ago (2015-09-16 17:26:07 UTC) #3
Cutch
PTAL
5 years, 3 months ago (2015-09-16 17:45:07 UTC) #4
turnidge
lgtm
5 years, 3 months ago (2015-09-16 17:47:03 UTC) #5
Cutch
5 years, 3 months ago (2015-09-16 17:47:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eb3fe782007ed5b51969cddcbd937f151515386f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698