Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1352483002: Add benchmark output to compiler stats. (Closed)

Created:
5 years, 3 months ago by hausner
Modified:
5 years, 3 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add benchmark output to compiler stats. Add two compiler stats benchmarks to unit tests Sample output: xcodebuild/ReleaseIA32/run_vm_tests CorelibCompilerStats NumberOfTokens: 271148 NumClassesParsed: 730 NumFunctionsCompiled: 8987 NumFunctionsOptimized: 0 NumFunctionsParsed: 9694 NumTokensScanned: 0 tokens ScannerTime: 0 ms ScannerSpeed: 0 tokens/ms NumTokensParsed: 531066 tokens ParserTime: 262 ms ParserSpeed: 2026 tokens/ms NumTokensCompiled: 433816 tokens CompilerTime: 648 ms CompilerSpeed: 668 tokens/ms CodeSize: 4428 KB CodeDensity: 138 tokens/KB InstrSize: 3127 KB CorelibCompilerStats(RunTime): 694788 BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/bb097ec37f4d034622c8ba20cc97931fe1870d0e

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : review comments #

Patch Set 4 : fix merge error #

Patch Set 5 : mmmmmmerge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -33 lines) Patch
M runtime/vm/benchmark_test.cc View 1 2 3 chunks +56 lines, -1 line 0 comments Download
M runtime/vm/compiler_stats.h View 4 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/compiler_stats.cc View 7 chunks +98 lines, -24 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hausner
5 years, 3 months ago (2015-09-16 17:02:07 UTC) #2
siva
lgtm https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_test.cc#newcode71 runtime/vm/benchmark_test.cc:71: EXPECT(error.IsNull()); The 'EXPECT(error.IsNull())' line seems to make the ...
5 years, 3 months ago (2015-09-16 17:25:00 UTC) #4
hausner
Committed patchset #5 (id:80001) manually as bb097ec37f4d034622c8ba20cc97931fe1870d0e (presubmit successful).
5 years, 3 months ago (2015-09-16 18:18:43 UTC) #5
hausner
Thank you. https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_test.cc#newcode71 runtime/vm/benchmark_test.cc:71: EXPECT(error.IsNull()); On 2015/09/16 17:25:00, siva wrote: > ...
5 years, 3 months ago (2015-09-16 18:21:01 UTC) #6
rmacnak
5 years, 3 months ago (2015-09-16 19:16:38 UTC) #7
Message was sent while issue was closed.
On 2015/09/16 18:21:01, hausner wrote:
> Thank you.
> 
>
https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_te...
> File runtime/vm/benchmark_test.cc (right):
> 
>
https://codereview.chromium.org/1352483002/diff/20001/runtime/vm/benchmark_te...
> runtime/vm/benchmark_test.cc:71: EXPECT(error.IsNull());
> On 2015/09/16 17:25:00, siva wrote:
> > The 'EXPECT(error.IsNull())' line seems to make the check above
> > if (!error.IsNull()) {
> >   ...
> > }
> > redundant.
> 
> Done, also in the the code above.

Divide-by-zero:

Program received signal SIGFPE, Arithmetic exception.
0x0000000000895060 in dart::CompilerStats::PrintToZone (this=0x3385e90) at
runtime/vm/compiler_stats.cc:275
275	            (1000 * num_func_tokens_compiled) / compile_usecs);

Powered by Google App Engine
This is Rietveld 408576698