Remove flaky markers from status file for tests that are not flaky.

Remove flaky markers from status file for tests that are not flaky.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32553

[kustermann, 2014-02-11 11:48:59]

@cc people: Just FYI.

[ricow1, 2014-02-11 11:52:13]

lgtm, have all those bugs been closed?

https://codereview.chromium.org/135243005/diff/1/dart/pkg/pkg.status
File dart/pkg/pkg.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/pkg/pkg.status#oldcode106
dart/pkg/pkg.status:106: fixnum/test/int_64_test: Pass, Fail # Bug in JSC.
makes sense, we updated both ff and jsshell

[kustermann, 2014-02-11 11:56:07]

Committed patchset #1 manually as r32553 (presubmit successful).

[floitsch, 2014-02-11 11:57:44]

fyi.

https://codereview.chromium.org/135243005/diff/1/dart/tests/co19/co19-dart2js...
File dart/tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/135243005/diff/1/dart/tests/co19/co19-dart2js...
dart/tests/co19/co19-dart2js.status:550:
LibTest/typed_data/Int32List/toList_A01_t01: timeout # co19-roll r559: Please
triage this failure
I think this one sometimes succeeds on our local machines.

https://codereview.chromium.org/135243005/diff/1/dart/tests/co19/co19-dart2js...
dart/tests/co19/co19-dart2js.status:558:
LibTest/typed_data/Uint32List/toList_A01_t01: timeout # co19-roll r559: Please
triage this failure
maybe the same.

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
File dart/tests/language/language_analyzer.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
dart/tests/language/language_analyzer.status:205:
override_inheritance_field_test/33: MissingStaticWarning, Pass # Issue 16498
These tests are dependent on the machine. They don't flake on the build-bot but
do on our machines.
(At least that's what the issue says, and I do remember that the analyzer has
some issues with that).

https://codereview.chromium.org/135243005/diff/1/dart/tests/standalone/standa...
File dart/tests/standalone/standalone.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/standalone/standa...
dart/tests/standalone/standalone.status:12: issue14236_test: Crash, RuntimeError
# Issue 14516.
I added this line recently. The crash is basically completely non-deterministic,
and I had one case, where it just failed instead of crashing.

[kustermann, 2014-02-11 12:54:35]

https://codereview.chromium.org/135243005/diff/1/dart/tests/co19/co19-dart2js...
File dart/tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/135243005/diff/1/dart/tests/co19/co19-dart2js...
dart/tests/co19/co19-dart2js.status:550:
LibTest/typed_data/Int32List/toList_A01_t01: timeout # co19-roll r559: Please
triage this failure
On 2014/02/11 11:57:44, floitsch wrote:
> I think this one sometimes succeeds on our local machines.

I'm not so sure about these. We trust the buildbot on what it produces. It has
been timing out for 100+ revisions. If we see differences on the bot and locally
someone should take a look, because there should be *no* differences.

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
File dart/tests/language/language_analyzer.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
dart/tests/language/language_analyzer.status:205:
override_inheritance_field_test/33: MissingStaticWarning, Pass # Issue 16498
On 2014/02/11 11:57:44, floitsch wrote:
> These tests are dependent on the machine. They don't flake on the build-bot
but
> do on our machines.
> (At least that's what the issue says, and I do remember that the analyzer has
> some issues with that).

Normally the analyzer is not flaky. Even if we run tests in the analyzer in bach
mode, the runs are independent of each other. Constantin confirmed that.

On the bots, these tests were passing consistently. 

And if the analyzer is non-deterministic, then it is probably not specific to
these tests I would assume.

https://codereview.chromium.org/135243005/diff/1/dart/tests/standalone/standa...
File dart/tests/standalone/standalone.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/standalone/standa...
dart/tests/standalone/standalone.status:12: issue14236_test: Crash, RuntimeError
# Issue 14516.
On 2014/02/11 11:57:44, floitsch wrote:
> I added this line recently. The crash is basically completely
non-deterministic,
> and I had one case, where it just failed instead of crashing.

I talked to florian schneider about it. This test should be removed or skipped
as it is now -- it provides no value. I replied on the bug.

It was consistently crashing on the bots for the last 100+ revisions.

[ricow1, 2014-02-11 12:57:01]

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
File dart/tests/language/language_analyzer.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
dart/tests/language/language_analyzer.status:205:
override_inheritance_field_test/33: MissingStaticWarning, Pass # Issue 16498
On 2014/02/11 12:54:36, kustermann wrote:
> On 2014/02/11 11:57:44, floitsch wrote:
> > These tests are dependent on the machine. They don't flake on the build-bot
> but
> > do on our machines.
> > (At least that's what the issue says, and I do remember that the analyzer
has
> > some issues with that).
> 
> Normally the analyzer is not flaky. Even if we run tests in the analyzer in
bach
> mode, the runs are independent of each other. Constantin confirmed that.
> 
> On the bots, these tests were passing consistently. 
> 
> And if the analyzer is non-deterministic, then it is probably not specific to
> these tests I would assume.

Except for the dart2analyzer, which will run on the vm, which may have flakes
(e.g., in optimized code)

[floitsch, 2014-02-11 13:00:15]

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
File dart/tests/language/language_analyzer.status (left):

https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
dart/tests/language/language_analyzer.status:205:
override_inheritance_field_test/33: MissingStaticWarning, Pass # Issue 16498
On 2014/02/11 12:57:01, ricow1 wrote:
> On 2014/02/11 12:54:36, kustermann wrote:
> > On 2014/02/11 11:57:44, floitsch wrote:
> > > These tests are dependent on the machine. They don't flake on the
build-bot
> > but
> > > do on our machines.
> > > (At least that's what the issue says, and I do remember that the analyzer
> has
> > > some issues with that).
> > 
> > Normally the analyzer is not flaky. Even if we run tests in the analyzer in
> bach
> > mode, the runs are independent of each other. Constantin confirmed that.
> > 
> > On the bots, these tests were passing consistently. 
> > 
> > And if the analyzer is non-deterministic, then it is probably not specific
to
> > these tests I would assume.
> 
> Except for the dart2analyzer, which will run on the vm, which may have flakes
> (e.g., in optimized code)
> 

the analyzer has a bug, where it is flaky dependent on the filename.
language/override_inheritance_field_test_10.dart is, for example one that flakes
100% depending on the name it has.
I'm not sure if these tests here are the same or not. Looking at the bug-report
it sounds likely.

[kustermann, 2014-02-11 13:00:20]

On 2014/02/11 12:57:01, ricow1 wrote:
>
https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
> File dart/tests/language/language_analyzer.status (left):
> 
>
https://codereview.chromium.org/135243005/diff/1/dart/tests/language/language...
> dart/tests/language/language_analyzer.status:205:
> override_inheritance_field_test/33: MissingStaticWarning, Pass # Issue 16498
> On 2014/02/11 12:54:36, kustermann wrote:
> > On 2014/02/11 11:57:44, floitsch wrote:
> > > These tests are dependent on the machine. They don't flake on the
build-bot
> > but
> > > do on our machines.
> > > (At least that's what the issue says, and I do remember that the analyzer
> has
> > > some issues with that).
> > 
> > Normally the analyzer is not flaky. Even if we run tests in the analyzer in
> bach
> > mode, the runs are independent of each other. Constantin confirmed that.
> > 
> > On the bots, these tests were passing consistently. 
> > 
> > And if the analyzer is non-deterministic, then it is probably not specific
to
> > these tests I would assume.
> 
> Except for the dart2analyzer, which will run on the vm, which may have flakes
> (e.g., in optimized code)

That might be true. But the status files are not up-to-date for that anyway
because it's only running on our FYI bot (and "basically" nobody will notice
redness there).